Skip to content

calibre: Add python unrardll#98430

Merged
doronbehar merged 2 commits intoNixOS:masterfrom
nyanloutre:add_python_unrardll
Dec 7, 2020
Merged

calibre: Add python unrardll#98430
doronbehar merged 2 commits intoNixOS:masterfrom
nyanloutre:add_python_unrardll

Conversation

@nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Sep 21, 2020 •
edited
Loading

Motivation for this change

CBR format was not supported without this lib.
Close #86152

Also, Calibre will not start without this patch #98197

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 21, 2020
@nyanloutre
Copy link
Member Author

nyanloutre commented Sep 22, 2020

Also it's maybe not useful to change the license type to unfreeRedistributable as the unrar package is now a dependency

@gebner
Copy link
Member

gebner commented Sep 22, 2020

Also it's maybe not useful to change the license type to unfreeRedistributable as the unrar package is now a dependency

The license is already an if-then-else. This is also the reason unrar support is disabled by default. IIRC there was also a free unrar library that we could use.

doronbehar
doronbehar reviewed Sep 22, 2020
View reviewed changes
veprbl
veprbl approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested calibre build on x86_64-linux (NixOS)

@doronbehar doronbehar merged commit c3ae8cd into NixOS:master Dec 7, 2020
@rfl890 rfl890 mentioned this pull request Feb 26, 2025
Open
@nyanloutre nyanloutre deleted the add_python_unrardll branch December 22, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doronbehar doronbehar doronbehar left review comments

@veprbl veprbl veprbl approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

+1 more reviewer

@gebner gebner gebner left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

calibre: No module named unrardll

4 participants

@nyanloutre @gebner @veprbl @doronbehar